Ticket #518 (new enhancement)

Opened 7 years ago

Last modified 5 years ago

Investigate possilbe problems with CellGrid

Reported by: prock Owned by: FIFE
Priority: normal Milestone: 0.3.5
Component: engine/core/model Version: trunk
Severity: normal Keywords: CellGrid
Cc: Blocked By:
Blocking: Time planned:
Time remaining: Time spent:


If you take a quick look at CellGrid? and how it's used you'll notice that Model owns it. If you ask Model for a CellGrid? by type it will clone a grid (if it finds it) and pass you a pointer to a new instance and adding the new instance to the end of it's list. The properties of the grid are cloned excluding the allow_diagonals property.

On a side note you'll notice also that the "m_allow_diagonals" property will always be the default because there is no way to modify it.

This ticket is to look at the current cell grid implementation and re-design/clean it up.

Change History

comment:1 Changed 7 years ago by prock

(In [3549]) * Modified the owner of CellGrids?. They are now owned by Layer.

  • Made Model more of a Factory class for CellGrids?. I'm not sure this is exactly what we should be doing but it does allow clients to add their own CellGrids?. Perhaps the best way to handle it would be to force the client to create their own grid a pass it to the Layer. refs #518

comment:2 Changed 7 years ago by prock

(In [3638]) * undid some changes I made in r3539 that modified the owner of cellgrids. I decided that this wasn't a useful change so I'm reverting it until this ticket can be looked at in more depth. refs #518

comment:3 Changed 7 years ago by prock

  • Milestone changed from 0.3.3 to 0.3.4

Moving this ticket to 0.3.4

comment:4 Changed 7 years ago by vtchill

(In [3693]) reverted the changes in the layerdialog to reflect the reverted changes in the engine core dealing with cell grids. This fixes the exception being thrown when modifying layer properties. refs #518

comment:5 Changed 5 years ago by prock

  • Milestone changed from 0.3.4 to 0.3.5

Moving to 0.3.5 as we are preparing to release 0.3.4

Note: See TracTickets for help on using tickets.